Jump to content

Photo

Help Test ePad/elmextensions Update


  • Please log in to reply
13 replies to this topic

#1 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 20 March 2015 - 04:36 AM

This evening I've added some updated code to elmextensions that great increases the user experience in the file selector widget that ePad uses. No longer does the application choke and practically die when navigating to directories with 1k+ files. It should now be smooth even in places that have a very large number of files. Previously opening /usr/bin caused ePad to lock on me for 3-5 seconds, now it opens without a hitch.

 

Please let me know if this update works well for you as I would like to get this into the main repo ASAP as it greatly improves the user experience.

 

The new version of ePad is 0.9.1 and the new version of elmextensions is 0.1.4





A big thank you to everyone who contributes to Bodhi Linux


#2 FameWolf

FameWolf

    Member

  • Members
  • 330 posts

Posted 20 March 2015 - 05:04 AM

This evening I've added some updated code to elmextensions that great increases the user experience in the file selector widget that ePad uses. No longer does the application choke and practically die when navigating to directories with 1k+ files. It should now be smooth even in places that have a very large number of files. Previously opening /usr/bin caused ePad to lock on me for 3-5 seconds, now it opens without a hitch.

 

Please let me know if this update works well for you as I would like to get this into the main repo ASAP as it greatly improves the user experience.

 

The new version of ePad is 0.9.1 and the new version of elmextensions is 0.1.4

 

Jeff..I forget which app specifically but a while back you posted about one where it needed newer elmextensions for full functionality..I think it was the pdf reader...will this elmextension version include the required changes for it? Sorry for the slightly off target question. If so then the pdf viewer would also benefit from increased responsiveness when selecting files?



#3 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 20 March 2015 - 05:40 AM

eeVee needs a new Elementary version - the core library that powers E and all E based applications. elmextensions sits on top of this.

 

Improving the load time of files in eeVee is next on my TODO list. The speed improvement here is only to the file selector widget. Not for the load time of large PDFs into eeVee.



#4 Nils

Nils

    Member

  • Members
  • 8 posts
  • LocationSweden

Posted 21 March 2015 - 09:40 PM

Hi there

 

I think it works well, but I wish there were better support for UTF-8.

 


There are three problems.

 

First, line 427 in fileselector.py needs to be like this

    data = os.listdir(unicode(ourPath))

Otherwise I wont be able to see autocomplete if my folder contains filenames with non-ascii.

 

Second problem, line 432 and 944 in epad needs to be like this

    newfile = io.open(file_selected, 'w')

Using builtin function open just creates an empty file if it contains non-ascii.

 

Third problem is that everywhere where you have a print command, and the output

is a filename or a path, python stops with an error if the name or path

contains utf-8.

Like this, line 463 in epad needs .encode('utf-8')

            print("File Selected: {0}".format(file_selected.encode('utf-8')))

 

This is just what I tested, and what works for me.



#5 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 21 March 2015 - 10:31 PM

I'll address the first two in the next set of updates. They aren't specific to the updates I've done here and will exist in all previous versions of ePad/fileselector

 

As for the last issue - I'll just comment out all the print statements. They are there for purely development debugging reasons and do not need full utf-8 support for such purposes.



#6 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 21 March 2015 - 11:08 PM

Just added these unicode improvements to the unstable branch.

 

Please let me know if they work for you Nils. Thanks for the report and for finding the fix :)

 

Welcome to the forums.



#7 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 22 March 2015 - 07:02 AM

I've added a pretty substantial backend recode of ePad to unstable this evening.

 

Please let me know if you notice any oddities in it. I tested everything I could think of, but it is 2am here and my best code doesn't always happen this late :)



#8 Nils

Nils

    Member

  • Members
  • 8 posts
  • LocationSweden

Posted 22 March 2015 - 01:53 PM

A quick test shows that you have a print command in line 399 in epad that prevents my file from opening.

 

And when I try to save an edited file I get this:

 

Traceback (most recent call last):

  File "efl/elementary/object_item.pyx", line 87, in efl.elementary.object_item._object_item_callback (efl/elementary/object_item.c:3149)

  File "/usr/bin/epad", line 1069, in <lambda>

    lambda self, obj: self._parent.saveFile())

  File "/usr/bin/epad", line 389, in saveFile

    self.tabbs.currentTab.button.text = os.path.basename(self.tabbs.currentTab.mainEn.file[0])

AttributeError: 'ePadEntry' object has no attribute 'button'



#9 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 22 March 2015 - 02:44 PM

A quick test shows that you have a print command in line 399 in epad that prevents my file from opening.

 

And when I try to save an edited file I get this:

 

Traceback (most recent call last):

  File "efl/elementary/object_item.pyx", line 87, in efl.elementary.object_item._object_item_callback (efl/elementary/object_item.c:3149)

  File "/usr/bin/epad", line 1069, in <lambda>

    lambda self, obj: self._parent.saveFile())

  File "/usr/bin/epad", line 389, in saveFile

    self.tabbs.currentTab.button.text = os.path.basename(self.tabbs.currentTab.mainEn.file[0])

AttributeError: 'ePadEntry' object has no attribute 'button'

 

Both of these should be fixed as of right now.



#10 Nils

Nils

    Member

  • Members
  • 8 posts
  • LocationSweden

Posted 22 March 2015 - 07:50 PM

Yes, thank you very much.



#11 Nils

Nils

    Member

  • Members
  • 8 posts
  • LocationSweden

Posted 10 April 2015 - 05:01 PM

Hello Jeff

Could you please add this to line 377 in fileselector.py

 

        for bk in self.getGTKBookmarks():

            bk = urllib.url2pathname(bk.encode('ascii')).decode('utf-8')

            con = Icon(self, size_hint_weight=EXPAND_BOTH,

 

Thank you



#12 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 10 April 2015 - 05:59 PM

Getting ready to head out of town for the weekend. Adding this to my que for Monday morning when I get back.



#13 The waiter

The waiter

    Module Master

  • Developer
  • 1424 posts
  • LocationBanska Bystrica, Slovakia

Posted 20 September 2015 - 05:36 PM

Hi Jeff

 

ePad question: line numbers are maybe 1 pixel higher than text on my desktop PC. All OK on the NTB. Could it be related to the screen resolution?

ePad suggestion: just a reminder. I love to have a textbox focus after starting ePad. Now I have to click the mouse in order to start writing

 

Thanx



#14 Jeff

Jeff

    Lead Developer

  • Developer
  • 12324 posts
  • LocationBloomington, IL

Posted 21 September 2015 - 10:03 AM

Some special characters are larger than other text. A bug in elementary.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users