Jump to content
  • 0
The waiter

Extra module fixing

Question

Hello

 

I have just fixed one of the moksha-extra-modules. I do not understand why but many modules are buggy or incomprehensibly weird. 

 

Forecasts module

  1. input dialog for entering a city code was just 1 pixel height :) It was impossible to put any text inside. Fixed,
  2. bad weather description position overlapped with temperature. Fixed,
  3. the code was prepared for 5 days forecast but it was apparently not finished. Anyway author could spend just a few minutes (instead of my hours) to make a slider and add some code. Fixed,
  4. If you select 5 days forecast, icons and line spacing increase. Fixed (wait for my another release).

 

Screenshot module

  1. it should have a camera sound during the grabbing. It was in the code but it did not work. I added a code and camera shooter sound to the sources (played via aplay). Fixed
  2. silly, too tiny camera icon on the shelf. Stupid bug in the code. Fixed today (wait for next release)
  3. 60 secs as default countdown timer. Sorry but ... :) lol, Fixed (next release)

Maybe I am wrong but as you can see, some modules are so sloppy so I wanted to devote this thread as a challenge for looking for another bugs or improvements. Please let me make these beautiful modules better:)

  • Like 4

Share this post


Link to post
Share on other sites

38 answers to this question

Recommended Posts

  • 0

Hello

 

I have just fixed one of the moksha-extra-modules. I do not understand why but many modules are buggy or incomprehensibly weird.

I think many modules are created as an afterthought merely to show users and other devs what is possible. Also some modules are created as an exercise in learning how to do it. And then sadly abandoned by the original author. For example see E17: Creation of a Moonclock module - Part 1

 

NOTE:

 This tutorial/blog post is badly dated and some of the information is not current and in addition some links may be broken. Part two on this tutorial you are going to have to find     elsewhere (thewayback machine) as the link is broke.

 

This explains why there are a few broken and or abandoned Modules, buggy modules and to many essentially toy modules that don't do anything useful.

 

Maybe I am wrong but as you can see, some modules are so sloppy so I wanted to devote this thread as a challenge for looking for another bugs or improvements. Please let me make these beautiful modules better:)

I really haven't had the time to look over many of the modules in moksha-modules-extra.  At least look over them in enough detail to find bugs or suggest improvements. However the whole point of FOSS is to make the code public and usable/editable by all. So you are doing a great job and certainly in the spirit of FOSS seva.  Much thanks :D

Share this post


Link to post
Share on other sites
  • 0

Hopefully the code is commented rather well.... but that would probably be more of a hoped for item. 

Share this post


Link to post
Share on other sites
  • 0

It is hoped that I could get my ideal rig set up soon enough so I can put extra effort into this worthwhile endeavor, but I would also like to express my gratitude for your work in this area, waiter. This way, even just adding comments and documentation would be good enough for me to say cant you see I'm busy? while updating the snow module. -_-

  • Like 1

Share this post


Link to post
Share on other sites
  • 0

Commenting code is good... Its a practice I have tried to maintain over the years.  Especially for customers who end up owning the code and have to maintain it.

Share this post


Link to post
Share on other sites
  • 0

Today I realized there were more useful modules which I used in the past under bodhi but I totally forgot them. Having some time today thus I compiled and created working debs of these ones:

 

photo-moksha - a picture box with slideshow on your desktop

mail-moksha - mail module/widget for checking your incoming mail 

news-moksha - RSS feed module

 

Modules are right now ready for testing and if are built properly, wait for another nice stuff :)

 

Enjoy

 

PS: not able to find a calendar module source code. Could you help me please?

  • Like 1

Share this post


Link to post
Share on other sites
  • 0

I have just found a site with source code of many and many e17 modules. Calendar was among them and it is now on my desktop. I will try to bring to live all nice or usefull modules. 

 

Modules which compiling and installing was successful:

 

Calendar

Snow

Winselector 

 

:)

  • Like 1

Share this post


Link to post
Share on other sites
  • 0

Hmm I don't know why but page above doesn't work anymore. What a pity I didn't download all modules. Anyway 

 

alarm-moksha (module for setting up time to alarm you)

calendar-moksha (gadget on desktop with actual date and calendar when click)

diskio-moksha (disc activity gadget)

slideshow-moksha (automatic or manual desktop wallpapers changing gadget)

snow-moksha (snow flakes on your desktop will bring you a winter mood :))

winselector-moksha (windows switching gadget)

winlist-moksha (enhanced windows switching gadget - activate it with CTRL-ALT-"," or CTRL-ALT-"."))

for more info https://github.com/shr-project/enlightenment/tree/master/E-MODULES-EXTRA/winlist-ng

 

Winselector and winlist are better than default windows switcher appearing after ALT+TAB, because they can choose the app running on different desktops.

 

These modules were sent for testing and as usual after a while you can install them when Jeff puts them in the repository.

 

Enjoy :)

Share this post


Link to post
Share on other sites
  • 0

Waiter, an huge thank you for this great works of resurrection. I really miss alarm module and winselector is pretty cool!

It seems that winlist-moksha goes conflict with Ecomorph. Anybody else find this issue?

Share this post


Link to post
Share on other sites
  • 0

I have found another perhaps great module. It is the trash module. I have successfully compiled and installed it. I have just two problems.

1. It uses as default Thunar for opening trash. There is no problem in sources put PcmanFM but it is need to be recompiled. The easy way should be to have more debs like: trash-thunar-moksha nad trash-pcmanfm-moksha but it is not ideal. Ideal should be the possibility of choosing your favorite FM. This is the hard way. I need to put extra code for showing the setting menu and a textbox for putting the name of FM and save/open it. Really enough work with unclear result... 

2. the second issue is, I am not able to put gagdet on the desktop, just on the shelf. It needs again my attention for understanding the code and fixing it.

 

In general I need to know if this is worth my struggling. Is anybody here who could use this gadget? Let me know please...

Share this post


Link to post
Share on other sites
  • 0

I have became interested in modules in general so of course I would like to see it working. Esp Option 2 which I know is much more work.

Share this post


Link to post
Share on other sites
  • 0

Good news after 4 hours work:

 

  • Trash is now possible to place on the desktop. I don't understand why author didn't want to show icon on desktop. Agrr it was a hell to find the right line with a bug
  • There was another issue I didn't expect. When I clicked on the trash on desktop > 0, nothing happened. I found out, thunar was opened only on the desktop 0. I added a code for checking on which zone/desktop we are and opens FM on current desktop. Fixed :)

Maybe I will release the first version which is usable since today. I will change thunar to pcmanfm as it is a default file manager in Bodhi...

 

http://imgur.com/0IV2cXP

  • Like 3

Share this post


Link to post
Share on other sites
  • 0
  • There was another issue I didn't expect. When I clicked on the trash on desktop > 0, nothing happened. I found out, thunar was opened only on the desktop 0. I added a code for checking on which zone/desktop we are and opens FM on current desktop. Fixed :)

 

When you get done playing with the trash module do you think you could look into the places source code? It has a similar bug. When it is set to use a custom file manager that file manager always opens in zone zero instead of the current desktop.

Share this post


Link to post
Share on other sites
  • 0

Places-moksha zone/desktop bug fixed

 

It works great with Thunar but there is a small trick with PCmanFM. In the input box under the places settings you have to put pcmanfm -n. It will open a new instance of FM. Without this parameter, places module will always open a new tab of FM on the desktop where pcman was firstly opened.

 

The same behavior pays for the trash module although I put pcmanfm -n in the code and compiled. I will try to make a setting dialog for choosing FM in the future.

 

trash-moksha

places-moksha

net-moksha (network activity indicator)

 

Are ready to use here

 

Debs are coming soon :)

Share this post


Link to post
Share on other sites
  • 0

All modules in the repository. Thanx Jeff...

 

Don't forget to read my post above about pcmanfm entry for places-moksha.

 

Enjoy and let me know if something goes wrong.

Share this post


Link to post
Share on other sites
  • 0

Good news after 4 hours work:

 

  • Trash is now possible to place on the desktop. I don't understand why author didn't want to show icon on desktop. Agrr it was a hell to find the right line with a bug
  • There was another issue I didn't expect. When I clicked on the trash on desktop > 0, nothing happened. I found out, thunar was opened only on the desktop 0. I added a code for checking on which zone/desktop we are and opens FM on current desktop. Fixed :)

Maybe I will release the first version which is usable since today. I will change thunar to pcmanfm as it is a default file manager in Bodhi...

 

http://imgur.com/0IV2cXP

 

 

I believe the author of trash did wish the gadget to show on the desktop. See his old google code page. I think development on Enlightenment is like trying to hit a moving target, changes in Enlightenment Foundation Library or in e itself break the API far too often. Just out of curosity which line did you have to change? I was looking at an old module, maybe Drawer (not sure now) which also didn't work added to the desktop ...

  • Like 1

Share this post


Link to post
Share on other sites
  • 0

https://github.com/JeffHoogland/moksha-modules-extra/commit/e5664f522b2a461d530ded48855964f10fba6ab2

 

166 static Eina_Bool
167 _gc_in_site(E_Gadcon_Site site)
168 {
169  //return (site != E_GADCON_SITE_DESKTOP);
170   return EINA_TRUE;
171 }
 
When I removed "!" from the line 169, it started to work. Then I looked at another module code and author just returns EINA_TRUE. Is it a signal for showing a gadget on the desktop? I have no idea.  :) Both options are OK. I decided to put the second one. 
  • Like 1

Share this post


Link to post
Share on other sites
  • 0

I have just compiled drawer for you. Yes, it is not possible to place it on the desktop but two error dialogs appears here immediately after placing, moksha restarts and the gadget disappears. Some plugins are not able to open. Anyway, it is configurable from the shelf. But I know nothing about this module so no knowledge what to set, what to expect....Tell me more about this module please

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×